unresolved symbols from value.cpp/.h

[Maks Orlovich]

On Friday 20 January 2006 10:37, Christian Ehrlicher wrote:
> Hi,
>
> While trying to get kj\s compile on windows, I now have some problems
> with unresolved smybols. It looks like there are a lot of functions not
> implemented:

Hi. 
This chunk is definitely NOT good:


-    KJS_EXPORT static bool collect();
+    static bool collect();

Ditto for this:

--- internal.h  (revision 500568)
+++ internal.h  (working copy)
@@ -403,7 +403,7 @@
     bool hasInstance(ExecState *exec, ValueImp *value);
 
     virtual const ClassInfo *classInfo() const { return &info; }
-    KJS_EXPORT static const ClassInfo info;
+    static const ClassInfo info;


Also, IMHO, you shouldn't  do these:
-  struct ClassInfo {
+  class ClassInfo {
+  public:

but rather fix the uses.

>
> ValueImp::operator=
> ValueImp::ValueImp(class KJS::ValueImp const &)

This is intentional, to prevent accidental copying.

>
> also it looks like kxmlcore doesn't export anything but kjs depends on
> kxmlcore.

There are no out-of-line symbols there except in debug builds. It probably 
shouldn't even build a library.

-Maks