Standard gettext PO format

[Nicolas Goutte]

On Tuesday 03 January 2006 15:48, Chusslove Illich wrote:
> >> [: Chusslove Illich :]
> >> http://caslav.gmxhome.de/misc/kdecore_p1.patch (patched original)
> >> http://caslav.gmxhome.de/misc/kdecore_p2.patch (using Gettext)
> >
> > [: Nicolas Goutte :]
> > I have not looked at the URLs, but I think that if you can use the
> > original Gettext (without having a toougly KDE code), then it should be
> > the preference.

I have taken the time to look at the patches. The second patch (using the new 
Gettext runtime) seems good and much better than continuing to hack the 
current Gettext/GLIbc runtime.

Just a little optimization detail: perhaps using char(4) will be better than 
using '\004' and especially "\004" (QByteArray::append and 
QByteArray::indexOf have variants that accept directly char.)

>
> So... Commit or wait a bit more? The last kdelibs snapshot was yesterday,
> so it might be fine to commit now and see if any problems arise before
> next snapshot.

Is there any source incompatibility? If not, then I suppose that you can 
commit without any problem. I would consider adding the Gettext runtime to 
kdelibs too.

If the source change is so complex that you would need special changes in 
non-kdelibs modules to compile both with the snapshot or with your change, 
then I do not know how such incompatibilities are normally handled.

Have a nice day!