KUrl(QString) fix
Ralf Habacker
ralf.habacker at freenet.de
Fri Dec 29 23:13:16 GMT 2006
Aaron J. Seigo schrieb:
> On Wednesday 20 December 2006 10:52, Ralf Habacker wrote:
>
>> Unfortunally KUrl::path() is an inline function. :-(
>>
>
> ugh. inline functions in our public API. not good.
>
> i can only imagine this was done for performance purposes. was it actually
> measured?
>
>
No answers ? I'm going to add two additional method to KUrl next
Tuesday according our last KUrl path problems on windows thread and
discussion with David :
QString toLocalFile() const;
QString toLocalFile(AdjustPathOption trailing ) const;
from which the following could be implemented inline like path() is
QString toLocalFile() const { return QUrl::toLocalFile(); }
or not inline:
QString toLocalFile() const;
Which one is prefered ? Are there common rules for this ?
If there are no objectivities, I would make it not inlined
Ralf
More information about the kde-core-devel
mailing list