KRandomSequence's methods constness and naming issues

[Robert Knight]

> Although I'm not sure what better names to propose. Anyone?

Since these are values from a sequence, perhaps nextTypeName() would be best.

eg.  nextBool() , nextInt().

> Can this change somehow break compilation of other modules?

I don't think so.  I think it will change the method signatures ( and
therefore break the ABI ), so a recompile will be needed - but if you
are doing this in KDE 4 kdegames this isn't a problem.

Regards,
Robert.

On 15/12/06, Dmitry Suzdalev <dimsuz at gmail.com> wrote:
> Hi!
>
> I've seen a lot of use of KRandomSequence in kdegames, but today I
> found that it's getters aren't const.
> It came as a surprise :).
>
> Here's a quick patch that fixes this.
>
> Can I commit it?
> Can this change somehow break compilation of other modules? I think it
> can't, am I right? :)
>
> Also, perhaps a better methods naming would be good.
> Didn't the style guidelines state that there's no need in 'get' prefix
> for getters and that method names shouldn't start with a  capital
> letter?
>
> Although I'm not sure what better names to propose. Anyone?
>
> Cheers,
> Dmitry.
>
>
>