KInstance and KIconLoader

David Faure faure at kde.org
Mon Dec 11 15:04:10 GMT 2006


On Monday 11 December 2006 15:45, Friedrich W. H. Kossebau wrote:
> Am Montag, 11. Dezember 2006 15:34, schrieb David Faure:
> > KIconLoader is the main reason kdecore still needs QtGui, but the problem
> > is KInstance::iconLoader and KGlobal::iconLoader, which return iconloader
> > instances.
> <...>
> > Any other ideas?
> 
> Split KGlobal into KCoreGlobal and KUIGlobal?

KGlobal is just convenience methods around the global instance. So I guess you mean splitting KInstance itself.
This seems to me a rather muddy concept to me; especially if this is only for the benefit of kiconloader.
There's no additional data in KUIInstance compared to KCoreInstance, so there's no real reason to inherit
from KCoreInstance just to provide a convenience method - I think the class names kill all convenience already ;)

Simon suggested on irc to refcount the kiconloaderprivate, this sounds like a good idea except
if we keep creating and deleting them because nothing holds a reference to them in the longer term...

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list