koffice/krita/ui

[Sebastian Sauer]

SVN commit 577164 by sebsauer:

Since this is another case where something crashes now at exact the same place deep inside Qt4-snapshot what worked before, I suspect a prob in Qt4 itself... So, seems a Pixmap that isNull() could crash QX11PaintEngine.

QPainter::begin: Cannot paint on a null pixmap
 
Program received signal SIGSEGV, Segmentation fault.
0xb652e0e8 in QX11PaintEngine::updatePen (this=0x8a2ca20, pen=@0xbf8c62a4)
    at painting/qpaintengine_x11.cpp:1284
1284        } else if (d->pdev->devType() == QInternal::Pixmap && d->pdev_depth == 32
(gdb) bt
#0  0xb652e0e8 in QX11PaintEngine::updatePen (this=0x8a2ca20, pen=@0xbf8c62a4)
    at painting/qpaintengine_x11.cpp:1284
#1  0xb652e517 in QX11PaintEngine::updateState (this=0x8a2ca20, state=@0x8a2d9b8)
    at painting/qpaintengine_x11.cpp:1123
#2  0xb64d25f7 in QPainterPrivate::updateState (this=0x8a2d610, newState=0x8a2d9b8)
    at painting/qpainter.cpp:552
#3  0xb64dab1a in QPainter::eraseRect (this=0xbf8c64d8, r=@0xbf8c6470) at 
painting/qpainter.cpp:5095
#4  0xb7ef1a9b in QPainter::eraseRect (this=0xbf8c64d8, x=0, y=0, w=0, h=0)
    at /opt/qt4-copy/include/QtGui/qpainter.h:632
#5  0xb7ef71e2 in KisRuler::drawRuler (this=0x8843ef0) at 
/home/kde4/koffice/krita/ui/kis_ruler.cc:199
#6  0xb7ef7b1d in KisRuler::recalculateSize (this=0x8843ef0)
    at /home/kde4/koffice/krita/ui/kis_ruler.cc:108
#7  0xb7ef7b9a in KisRuler::setZoom (this=0x8843ef0, zoom=1)
    at /home/kde4/koffice/krita/ui/kis_ruler.cc:128
#8  0xb7f27ab8 in KisView::zoomAroundPoint (this=0x8757ef0, x=0, y=0, zf=1)
    at /home/kde4/koffice/krita/ui/kis_view.cc:1480
#9  0xb7f24d50 in KisView::setCurrentImage (this=0x8757ef0, image=@0xbf8c66a8)
    at /home/kde4/koffice/krita/ui/kis_view.cc:3659
#10 0xb7f24e21 in KisView::slotLoadingFinished (this=0x8757ef0)
    at /home/kde4/koffice/krita/ui/kis_view.cc:3846
#11 0xb7f2a167 in KisView (this=0x8757ef0, doc=0x817b6b8, adapter=0x817b744, parent=0x867ddb8)
    at /home/kde4/koffice/krita/ui/kis_view.cc:356
#12 0xb7eb8f6e in KisDoc::createViewInstance (this=0x817b6b8, parent=0x867ddb8)
    at /home/kde4/koffice/krita/ui/kis_doc.cc:873
#13 0xb75f59a5 in KoDocument::createView (this=0x817b6b8, parent=0x867ddb8)
    at /home/kde4/koffice/libs/kofficecore/KoDocument.cpp:339
#14 0xb761cc31 in KoMainWindow::setRootDocument (this=0x84f8d28, doc=0x817b6b8)
    at /home/kde4/koffice/libs/kofficecore/KoMainWindow.cpp:387

CC_MAIL: kde-core-devel at kde.org



 M  +1 -1      kis_ruler.cc  


--- trunk/koffice/krita/ui/kis_ruler.cc #577163:577164
@@ -190,7 +190,7 @@
     qint32 st4 = 0;
     qint32 stt = 0;
 
-    if (!m_pixmapBuffer)
+    if (!m_pixmapBuffer || m_pixmapBuffer->isNull())
         return;
 
     p.begin(m_pixmapBuffer);