[PATCH] Folder icons reflect contents

[Aaron J. Seigo]

On Tuesday 08 August 2006 10:45, Remi Villatel wrote:
> > oh, wait.. i see you don't have an svn account. if you'd like, please
> > request one so you can manage your own patches and work with the kde
> > project with a bit more ease ... no point in having to wait for me or
> > someone else commit your fixes, features, etc once agreed upon..  =)
>
> I'll do that for my next patches. In the mean time, here's another one:

just to be clear, i haven't actually committed any of your patches; there's no 
rush to get them in since 3.5.4 just went out so there's lots of time for you 
to get your account and do the commits yourself ... more fun that way =)

> *kdebase/libkonq/kfileivi.cc.diff*
>
> The option "Folder icons reflect contents" never worked for me. I was
> wandering in the sources and I found why. It worked only if the name of
> the folder icon is _exactly_ "folder". With my customized icontheme,
> it's "folder1" so it couldn't work. And even without any special
> icontheme, if you set the icon of a folder to "folder_green",
> "folder_yellow" or "folder_whatever", it won't work. This tiny patch
> solves the problem.

your patch will fail if the folder icon doesn't start with "folder". probably 
a more comprehensive fix would be to use something like:

m_fileItem->iconName() != KMimeType::mimeType("inode/directory")->icon()

as for performance, making that exact KMimeType call 1,000,000 times takes 
~8.7 seconds on my 1.8Ghz laptop ... so that shouldn't be a problem.

> Now, I'm gonna request my SVN account. I think I'm addicted to patching.
> ;-)

hehe.. yep, it's quite addictive.. er.. fun! yeah. that's it. fun ;)

-- 
Aaron J. Seigo
Undulate Your Wantonness
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060808/ed1443ff/attachment.sig>