RFC: KWizard

[Olivier Goffart]

Le vendredi 4 août 2006 07:51, Tobias Koenig a écrit :
> On Thu, Aug 03, 2006 at 08:49:22PM +0200, Olivier Goffart wrote:

> Could you adapt the coding style to our official (Qt4) kdelibs
> coding style, please?

ok

>
> > 	private slots:
> > 		void setNextEnabled(bool);
> > 		void slotCurrentPageChanged();
>
> Move these to KWizardPrivate as well, please. Hide as much private data
> in public API as possible...

But they are slot, they need to be in that header anyway.
Q_PRIVATE_SLOT is not public api
and changing private method of a class is source and binary compatible.
so this is already not public API

Or do you want that we use he set of qt macro Q_D ......
(like this is in phonon) in the whole kdelibs ?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060804/7a5b7818/attachment.sig>