Suspicious code in kdeedu-3.5.2

[Albert Astals Cid]

A Dissabte 22 Abril 2006 13:50, Christoph Bartoschek va escriure:
> Am Samstag, 22. April 2006 13:13 schrieb Albert Astals Cid:
> > > - blinken/src/blinken.cpp:442
> > >
> > > i can become 4 if selected is always false. Then the else part in line
> > > 434 is chosen and in line 442 you have an out of bounds access.
> >
> > Errrrrrm, how?
> > line 444 (i guess you speak about that) has
> > m_buttons[button] -> setSelected(true);
> > and button is always >= 0 && <= 3
>
> Ok, an assertion would make this clear. But I reported this because I had
> the if condition in line 436 in mind. My fault.

No problem, this suspicios mails are very nice :-)

I'll add the assert.

Albert

PS: BTW i'm having a look at the kdegraphics/kpdf too, just that those are 
more difficult to check.

>
> Christoph

		
______________________________________________ 
LLama Gratis a cualquier PC del Mundo. 
Llamadas a fijos y móviles desde 1 céntimo por minuto. 
http://es.voice.yahoo.com