Suspicious code in kdewebdev-3.5.2

[Andras Mantia]

Hi,

 First of all thank you for your report! 

On Friday 21 April 2006 22:43, Christoph Bartoschek wrote:
> ------------------------------------------------------------------
> Misc problems:
> ------------------------------------------------------------------
>
> - kxsldbg/kxsldbgpart/libxsldbg/options.cpp:360
>
> The if condition in line 359 looks strange for me. But here I would
> expect type - OPTIONS_FIRST_OPTIONID.

I don't know, maybe the author of the code will react.

> - kxsldbg/kxsldbgpart/libxsldbg/files_unix.cpp:119
> - kxsldbg/kxsldbgpart/xsldbgconfigimpl.cpp:153
> - quanta/treeviews/templatestreeview.cpp:226
> - quanta/treeviews/templatestreeview.cpp:102
> - kommander/widgets/closebutton.cpp:138
> - quanta/components/debugger/gubed/quantadebuggergubed.cpp:378
> - quanta/components/debugger/dbgp/dbgpnetwork.cpp:239
> - quanta/project/projectupload.cpp:409
> - quanta/project/projectprivate.cpp:1503
> - quanta/parsers/node.cpp:366
> - quanta/parsers/node.cpp:340 (similar)
> - quanta/components/tableeditor/tableeditor.cpp:492
> - quanta/components/tableeditor/tableeditor.cpp:518

All of the above are fixed now.

> - quanta/parts/kafka/kafkahtmlpart.cpp:1152
>
> deactivated code?

Possibly, but I don't touch this as I have no idea what it is about and 
the author is not active now. It will be rewritten for KDE4 anyway.

> ------------------------------------
> Problems involving the NULL pointer:
> ------------------------------------
>
> - kimagemapeditor/kimedialogs.cpp:424
> - kxsldbg/kxsldbgpart/xsldbgdebugger.cpp:97
> - kxsldbg/kxsldbgpart/libxsldbg/debugXSL.cpp:619
> - quanta/parts/kafka/wkafkapart.cpp:2158
> - quanta/parts/kafka/wkafkapart.cpp:1484
> - quanta/parts/kafka/kafkacommon.cpp:1990
> - quanta/parts/kafka/kafkacommon.cpp:2068
> - quanta/parts/kafka/kafkacommon.cpp:1573
> - quanta/parts/kafka/kafkacommon.cpp:236 (similar)
> - quanta/parts/kafka/kafkacommon.cpp:180 (similar)
> - quanta/parts/kafka/htmldocumentproperties.cpp:420
> - quanta/components/debugger/dbgp/dbgpnetwork.cpp:56
> - quanta/components/debugger/dbgp/dbgpnetwork.cpp:134
> - quanta/parsers/dtd/dtdparser.cpp:262
> - kommander/widgets/subdialog.cpp:106
Above issues are fixed now.

> - kommander/editor/actioneditorimpl.cpp:90
> - kommander/editor/actioneditorimpl.cpp:101
>
> In line 88 the Pointer currentAction is deleted. Is its usage legal
> here?

I don't know, it's some code from Qt Designer. ;-)

> - quanta/project/projectupload.cpp:421
>
> A dynamic_cast indicates that the result can be NULL.

Not really, but changed the code to be more clear.

> -----------------------------------------------------------------
> Cases from switch statements that fall through in some cases but
> do not have a fall through comment as in most such cases.
> ------------------------------------------------------------------
>
> - kommander/editor/formfile.cpp:178

Comment added.

> -----------------------------------------------------------------
> Lines where boolean expressions are used in non-boolean contexts:
>
> I suspect that at least the lines marked with !!! are bugs
> -----------------------------------------------------------------
>
>
> - quanta/project/project.cpp:914  (why  > 0)

Fixed.

> - kxsldbg/kxsldbgpart/libxsldbg/option_cmds.cpp:95

I leave this to the author to fix.

Andras

-- 
Quanta Plus developer - http://quanta.kdewebdev.org
K Desktop Environment - http://www.kde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060422/3a9ed8ef/attachment.sig>