Suspicious code in kdeedu-3.5.2

Albert Astals Cid aacid at kde.org
Sat Apr 22 12:13:55 BST 2006


A Dissabte 22 Abril 2006 12:59, Christoph Bartoschek va escriure:
> So, the last report for kde 3.5.2:
>
> ------------------------------------------------------------------
> Misc problems:
> ------------------------------------------------------------------
>
> - kgeography/src/answer.cpp:101
>
> If line 91 is also false, then widgets[i] is not initialized here.

Never happens, one of the three ifs is guaranteed to be true.

>
> - blinken/src/blinken.cpp:442
>
> i can become 4 if selected is always false. Then the else part in line
> 434 is chosen and in line 442 you have an out of bounds access.

Errrrrrm, how? 
line 444 (i guess you speak about that) has
m_buttons[button] -> setSelected(true);
and button is always >= 0 && <= 3


Albert

	
	
		
______________________________________________ 
LLama Gratis a cualquier PC del Mundo. 
Llamadas a fijos y móviles desde 1 céntimo por minuto. 
http://es.voice.yahoo.com





More information about the kde-core-devel mailing list