Suspicous code in kdelibs-3.5.2

Michael Pyne michael.pyne at kdemail.net
Sat Apr 8 14:06:46 BST 2006


On Saturday 08 April 2006 09:59, Cristian Tibirna wrote:
> > -----------------------------------------------------------------
> > Cases from switch statements that fall through in some cases but
> > do not have a fall through comment as in most such cases.
> > ------------------------------------------------------------------
>
> [cut]
>
> > - kdeprint/management/kmwname.cpp:66
>
> What a "fall through comment is"?  That code is correct.

Just a comment acknowledging that the developer knows that code execution 
will "fall through" into the next case.

e.g.

switch (num) {
  case 1: blah();
  break;

  case 2:
    // Fall through
  case 3: blah_blah();
}

Regards,
 - Michael Pyne
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060408/8fed3944/attachment.sig>


More information about the kde-core-devel mailing list