Suspicious code in kdebase 3.5.2

[Ismail Donmez]

Hi Christoph,
Cumartesi 8 Nisan 2006 11:21 tarihinde, Christoph Bartoschek şunları yazmıştı: 
[...]
> - kwin/utils.cpp:313
>
> !(*dot = 0) is  always true and therefore unneccessary. Or do you mean
> !(*dot ==0)?

Indeed, fixed.

[...]

> - kdesu/kdesud/lexer.cpp:46
>
> This while(1) loop can be executed at most once.

Why?

>
> - konsole/konsole/BlockArray.cpp:214
>
> The buffer allocated at line 209 is leaked. Why do not use std::array<char>
> here?

Fixed.

> - kcontrol/fonts/kxftconfig.cpp:1137
>
> Dirs is always true and therefore && Dirs is not neccessary. Maybe &
> Dirs is meant?

Indeed, Dirs is an enum anyway. Fixed.

[...]
> - kcontrol/crypto/crypto.cpp:1980
>
> cr is allocated with operator new[] use delete []

Fixed.

Thanks for checking! 

Regards,
ismail
-- 
<Terwou> \\o \o> <o/ o//
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060408/4af6dbd1/attachment.sig>