Suspicous code in kdelibs-3.5.2 Part 2

[Christoph Bartoschek]

I forgot to check the .cc files in the first run.

------------------------------------------------------------------
Misc problems:
------------------------------------------------------------------

- libkmid/player.cc:365, 366

What happens when ev->length == 1024?  then the ?-condition  is false
and  pspev->text[1024] is overwritten. Off by one error.

- arts/kde/kiotestslow.cc:38

There is no argument for the %d parameter.

------------------------------------
Problems involving the NULL pointer:
------------------------------------

- libkmid/voiceman.cc:59

What happens when totalvoices == 1? Then nvoices == 1 and the for loop
in line 47 is never entered. Then LastVoice becomes ptr which is still 
NULL from line 45 and line 59 crashes.


-----------------------------------------------------------------
Cases from switch statements that fall through in some cases but 
do not have a fall through comment as in most such cases.
------------------------------------------------------------------

- kioslave/http/http.cc:1655

-----------------------------------------------------------------
Lines where boolean expressions are used in non-boolean contexts:
-----------------------------------------------------------------

- kioslave/http/http.cc:5890
- kioslave/http/http.cc:5884