Ch.Ehrlicher at gmx.de
Mon Apr 3 19:07:02 BST 2006
David Faure schrieb:
> On Sunday 02 April 2006 21:59, Christian Ehrlicher wrote:
>> Harri Porten schrieb:
>>> On Sun, 2 Apr 2006, Christian Ehrlicher wrote:
>>>> I tried to replace the macros from kde_file.h with the ones from
>>>> qplatformdefs.h (see TODO).
>>> I think I said this before: why switch to using private and undocumented
>>> API? One should point out that the qplatformdefs.h were *not* introduced
>>> with the idea of defining those Q* macros in mind. It's a wild
>>> collection of "evil" platform-specifc header files. Those includes (like
>>> the ones for networking) are still there so the dangerous side effects
>>> (all kinds of ugly #defines from system headers) are still there.
>>> kde_file.h on the other hand consists of namespace-clean KDE_* defines.
>>> If you want to replace that in favour of the Q_* defines I suggest to
>>> place a request with Trolltech to split qplatformdefs.h in two: one file
>>> for compat macros, one for risky #includes. Without that you are doing a
>>> step backwards in terms of code robustness.
> I agree.
>> It was not my idea, I just followed TODO.
> One of the problems of the TODO file is that it's kind of a brainstorming,
> it's not really an "official" list of "decisions" or something like that.
> So I think it's still a good idea to get confirmation here, before or after
> writing patches, to make sure the idea is good :)
>> I've no problems with kde_file.h.
> Can you revert to it?
> Thanks, and sorry that a misunderstanding leads to unnecessary work...
Ok, no problem. I'll revert it in the next days (at least before the
next kdelibs snapshot)
More information about the kde-core-devel