Moving 3 widgets to kdelibs.

[Benjamin Meyer]

On Friday 16 September 2005 5:32 pm, Tom Albers wrote:
> Hi,
>
> I would like to suggest to move/copy a couple of widgets to kdelibs.
>
> 1. KDateEdit [1]
> This class is also used by digiKam. The advantage of this class is that it
> gives a very user friendly way of navigating through dates, while collapsed
> it is only the normal height of a simple QLineEdit.
>
> 2. KDateTimeEdit [2]
> This is a simple extention i made to the above widget, which also includes
> the time. This widget is currently only used in digiKam, but might be
> usefull for other applications.
>
> Remarks:
> - for both two to work, kDatePickerPopup[3] class should be copied as well
> - the existing kdatewidget [4] and kdatetimewidget [5] are slightly
> different and should stay around for applications needing them or
> developers who prefer those two.

We shouldn't have both, only one.  For it to go in the other one should be 
removed.

> 3. SqueezedComboBox [6]
[snip] like simon said it probably isn't needed.

> All widgets are documented and contain screenshots.

That is really good.  I noticed that some of the functions aren't documented.  
The classes need to be fully documented.

> I'm able to maintain 
> the SqueezedComboBox if needed, the first one is not written by me and the
> second is to simple to need maintanance ;-)

Before going into libs all the classes must have maintainers.  We have enough 
classes right now that don't have maintainers.

> The only 'problem' is that i'm not into qt4 at all at this moment and can
> not do the move/copy myself.

The maintainers should be into qt4 so they can fix issues and bugs.

> Opinions?

Do they have QTestLibs based tests?  Before they are moved into libs they 
should have tests.

From a quick look I see some things that need improving:
-What is the point of KDateEdit::isReadOnly() ?  What is wrong with 
isDisabled()?
-KDateEdit should have a  Q_PROPERTY for setting/getting the date
-KDateTimeEdit should have a  Q_PROPERTY for setting/getting the datetime
-You shouldn't have "const char *name" in the constructors anymore. 
-They need private clases 
-KDatePickerPopup shouldn't be based upon Q3PopupMenu, but Qt4's QMenu
-Some of the files don't have copyrights that say 2005, they should be checked  
and updated .
A quick look over at http://kde.icefox.net/tests/ I see some other trivial 
things that should be fixed.

-Benjamin Meyer

-- 
aka icefox
Public Key: http://www.icefox.net/public_key.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050919/ff508f04/attachment.sig>