patch for KService

Jens Herden jens at kdewebdev.org
Fri Sep 9 15:20:52 BST 2005


Hello,

I propose the attached patch for KService. 
The background is that KService::icon() does not what the docs say:

  /**
   * Returns the name of the icon.
   * @return the icon associated with the service,
   *         or QString::null if not set
   */

Actually the return value is the string "unknown" when the icon is not set in 
the .desktop file. The consequence is that eg. in KBabel all validation tools 
get the "unkown" icon in the menu. 

OK to commit?

Jens
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kservice.diff
Type: text/x-diff
Size: 536 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050909/10d290b3/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050909/10d290b3/attachment.sig>


More information about the kde-core-devel mailing list