[Patch] fix compile of kdefx with msvc

Christian Ehrlicher Ch.Ehrlicher at gmx.de
Sun Oct 30 16:44:15 GMT 2005


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Maks Orlovich schrieb:

> On Sunday 30 October 2005 07:46, Christian Ehrlicher wrote:
> 
>>Hello,
>>
>>Here a small patch to fix compilation of kdefx with msvc.
> 
> 
> 
>>kstyle.cpp:
>>- removed wrong semicolion at end of if statement
> 
> 
> Eeek. Thanks for catching this.
This check seems to be missing in gcc - it was the second if-statement
int kdecore where msvc found this :)

> 
> 
> 
>>kstyle.h:
>>- struct -> class to avoid compiler warnings
> 
> 
> That's fine.
> 
> Can't comment on build stuff, though
It's not a big change here - the define is just for exporting classes
with msvc (and gcc4) and the remove of the lib suffix is ok too (see
kdecore/Sconssript for example).

Can someone please check this in?

Chrstian
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFDZPhfnNKwkgf+zVMRAgOlAKCoB/Rp94bTrQClWGmbw5tt0RHqrwCfY4sy
jHa1gyZ2oBEOTaQ6cZvfElQ=
=kTFH
-----END PGP SIGNATURE-----




More information about the kde-core-devel mailing list