Need help with kdesktop patch
Aaron J. Seigo
aseigo at kde.org
Wed Nov 16 18:37:55 GMT 2005
On Wednesday 16 November 2005 10:22, Kevin Krammer wrote:
reads ok. haven't test it yet, however.
not that it matters overly much here because these aren't in a hot path, but
for loops like:
for (unsigned i=0; i < m_Renderer[sdesk]->numRenderers(); ++i)
it's usually a good idea to cache the value instead of calling it every time
through the loop.
something that stood out was these two changes:
- KDesktopSettings::setLimitCache( (bool) bLimit );
- KDesktopSettings::setCacheSize( size );
- KDesktopSettings::setCommonDesktop( m_bCommon );
where is the change being made to KDesktopSettings (and if nowhere, why write
the config file out)? i couldn't find a place where the settings object was
getting updated; should it be?
> The last two are not so important:
why have backgroundConfigureDone when it just calls internalConfig? just
connect the signal to internalConfig and be done, no?
i'll test after we're doing chewing over the above items =)
also, since this has been there since 3.4.0 and isn't an overly serious issue,
this probably doesn't need to be in 3.5.0 (certainly 3.5.1 though) so we're
in no massive hurry.
certainly a lot of work to get kiosk right there =)
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the kde-core-devel