[PATCH] add dummy operator== and dummy qHash for win32 target
faure at kde.org
Mon Nov 7 15:31:30 GMT 2005
On Monday 07 November 2005 12:41, Christian Ehrlicher wrote:
> > Am Sonntag, 6. November 2005 11:58 schrieb Christian Ehrlicher:
> > > Stephan Kulow schrieb:
> > > > On Sunday 06 November 2005 11:06, Christian Ehrlicher wrote:
> > > >>The problem here is based on this discussion:
> > > >>http://lists.kde.org/?l=kde-core-devel&m=113061009510075&w=2
> > > >>I can make them private or mask them with an '#if MAKE_KDEUI_LIB' to
> > > >>avoid caling them from outside the lib. But with gcc you can call them
> > > >>too (and you'll get a linker error that gcc can't auto-create the
> > > >>operator) because the operator comes from QList<T>.
> > > >
> > > > But it won't be possible to create a QList<T> if the operator== is
> > > > private
> > >
> > > I've now put a '#ifdef MAKE_KDECORE_LIB' around to avoid using it
> > > outside the lib.
> > I've applied the dummy operator related stuff.
> > What about the .Modifier(s) stuff, Is this okay ?
> I think yes - Thiago Maceira just complained about because I was to lazy to
> send two separate patches for kdecore :)
Yes. My fault for forgetting the 's' there - that code is win32-only anyhow (and should probably
be cleaned up further at some point...)
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
More information about the kde-core-devel