[PATCH] add dummy operator== and dummy qHash for win32 target

Thiago Macieira thiago at kde.org
Sun Nov 6 13:19:00 GMT 2005


Christian Ehrlicher wrote:
>Thiago Macieira schrieb:
>> Christian Ehrlicher wrote:
>>>I've now put a '#ifdef MAKE_KDECORE_LIB' around to avoid using it
>>>outside the lib.
>>
>> I am Ok with this patch (at least the parts that touch my code).
>>
>> I couldn't understand the relevance of adding s to KeyboardModifier
>> :-)
>
>Because 'Qt::KeyboardModifiers QKeyEvent::modifiers () const' -> see
>also qnamespace.h: Q_DECLARE_FLAGS(KeyboardModifiers, KeyboardModifier)
>
>Is anyone there who can check in my patches?

I did, and I said they are ok.

But your patch contained changes that were completely unrelated (that 
KeyboardModifier stuff).

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

1. On frumscafte, hwonne time_t wæs náht, se scieppend þone circolwyrde 
wundorcræftlíge cennede and seo eorðe wæs idel and hit wæs gód.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20051106/74329b9a/attachment.sig>


More information about the kde-core-devel mailing list