[PATCH] cygwin related source patch (kdelibs/libkscreensaver)

[David Faure]

On Thursday 19 May 2005 14:38, ralf.habacker at freenet.de wrote:
> Am Mittwoch, 18. Mai 2005 17:01 schrieb David Faure:
> > On Wednesday 18 May 2005 16:53, Stephan Kulow wrote:
> > > On Wednesday 18 May 2005 12:05, ralf.habacker at freenet.de wrote:
> > > > Hi,
> > > >
> > > > here comes an additional patch for kdelibs/libkscreensaver as single
> > > > patch.
> > > >
> > > > windows does not support undefined symbols in dll's, libkscreensaver
> > > > must be build as static library.
> > >
> > > Better make it static for all platforms. These undefined references are
> > > really not good for a shared lib
> >
> > I agree.
> >
> > > Or does someone see a different way to fix this problem?
> >
> > Yes but source incompatible: a shared lib and a macro or template for the
> > main() code.
> 
> Unfortunally I don't feel comfortable changing this. Should I check in this as 
> static or with the conditional ? 

For compatibility reasons, it should remain a shared lib on already-supported-platforms
until KDE 4 (so better use the conditional, but please add a TODO in comments like
"KDE4: define a macro or template for the main() code to avoid undefined symbols" )

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).