[PATCH] KSaveFile::abort() on win32
Aaron J. Seigo
aseigo at kde.org
Wed Mar 30 16:30:46 BST 2005
On Wednesday 30 March 2005 08:58, Jarosław Staniek wrote:
> For win32: close is required _before_ unlinking.
>
> ok?
IMHO this is exactly the style of patch that should be avoided while porting
to a platform. doubly so for one that does things as differently as win32
from the rest of our target platforms.
instead of creating a mess of #if's that turn a clear two line method into 11
lines of spaghetti, can we instead just have two separate code paths? e.g.:
KSaveFile::abort()
{
#ifdef Q_WS_WIN
//for win32: close before unlinking
mTempFile.close();
if (!mTempFile.name().isEmpty())
QFile::remove(mTempFile.name());
#else
mTempFile.unlink();
mTempFile.close();
#endif
}
--
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050330/9982b572/attachment.sig>
More information about the kde-core-devel
mailing list