[PATCH] Emit warnings from Job, and forward them adequately in ForwardingSlaveBase

Matt Rogers mattr at kde.org
Thu Jul 14 00:55:40 BST 2005


On Wednesday 13 July 2005 03:42 pm, Adriaan de Groot wrote:
> On Wednesday 13 July 2005 18:23, Kévin Ottens wrote:
> > Could someone review the attached patch?
>
> Drat, I was getting all ready to bitch about missing API dox (as is my
> wont) and then I actually read the patch. Hats off, Kévin, to your
> diligence. Would that more people took such care with their interfaces and
> documentation.
>
> (So the _dox_ part of the patch is fine. I can't say about the
> functionality.)

except for the missing "@since" on the warning signal.
--
Matt




More information about the kde-core-devel mailing list