kdatetable keyboard navigation patch

Felix Berger bflat1 at gmx.net
Tue Jan 25 13:51:09 GMT 2005


On Tuesday 25 January 2005 10:26, David Faure wrote:

> I don't know KDateTable but the patch looks good. Maybe a comment about why
> KAccel is used for those keys instead of keyPressEvent would make the
> matter clear to the occasional source-code reader.

Thanks for having a look at the code. I can add some comments. So there are no 
objections against the changed behaviour that this patch introduces?

> > I don't know if the added private slots break BC though.
>
> No, they don't, so this is fine.

I guess the same question about public versus private slots applies here too.

Sincerely,
Felix

-- 
Use Debian GNU/Linux!
http://www.felix.beldesign.de/




More information about the kde-core-devel mailing list