[PATCH] fix process spinning out of control

George Staikos staikos at kde.org
Thu Feb 24 02:52:08 GMT 2005


When nspluginviewer is running and the konqueror window crashes or is killed 
with signal 9, the viewer process doesn't exit and thinks it's still 
embedded, resulting in an infinite loop of X errors.  It uses quite a bit of 
CPU, and looks like this:

X Error: BadDrawable (invalid Pixmap or Window parameter) 9
  Major opcode:  144
  Minor opcode:  3
  Resource id:  0x3c00023
X Error: BadWindow (invalid Window parameter) 3
  Major opcode:  3
  Minor opcode:  0
  Resource id:  0x3c00023
X Error: BadDrawable (invalid Pixmap or Window parameter) 9
  Major opcode:  144
  Minor opcode:  3
  Resource id:  0x3c00023
X Error: BadWindow (invalid Window parameter) 3
  Major opcode:  3
  Minor opcode:  0
  Resource id:  0x3c00023
X Error: BadDrawable (invalid Pixmap or Window parameter) 9
  Major opcode:  144
  Minor opcode:  3
  Resource id:  0x3c00023

[etc]

This patch changes the viewer to keep track of the dcop clients that are 
connected to it and kills their plugins when they go away.  If all clients go 
away, it exits.  I think this is a major fix and important for 3.4.  Any 
objections (other than removing the debug output)?

(There was a bug reported against this, and while the real problem is that 
Konqueror crashes, this should be fixed...)

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nsplugins-nospin.patch
Type: text/x-diff
Size: 4352 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050223/83dc2f68/attachment.patch>


More information about the kde-core-devel mailing list