Fwd: [PATCH] Hide completion tip correctly

[Andras Mantia]

This mail I sent yesterday to kwrite-devels, but I repost here to get 
the approval from a general audience. 
It cannot be called showstopper, but it's a (visually) ugly bug.

Andras

----------  Forwarded Message  ----------

Subject: [PATCH] Hide completion tip correctly
Date: Tuesday 22 February 2005 19:39
From: Andras Mantia <amantia at kde.org>
To: kwrite-devel at kde.org

Hi,

 Attached is a patch that makes sure that the completion tip is hidden
also if you simply click somewhere in the document while the completion
box is visible. The reason is the FocusOut is not emitted, so I picked
up Hide instead of it. Alternatively it might be enough to just delete
the m_commentLabel there.
 The bug is visible in Quanta (maybe we are the only one using the
 tip): type "<a " and you'll see the box starting with "charset" and
 "input" as the tip. Without the patch the "input" tip remains if you
 click somewhere in the document.

Please review and let me know if it's OK, so it can go in 3.4.

Andras

--
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org

-------------------------------------------------------

-- 
Quanta Plus developer - http://quanta.sourceforge.net
K Desktop Environment - http://www.kde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kate.diff
Type: text/x-diff
Size: 559 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050223/966a4538/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050223/966a4538/attachment.sig>