[PATCH] kconfig_compiler: fix inheritance

[Waldo Bastian]

On Wednesday 16 February 2005 19:05, Michael Brade wrote:
> Hi,
>
> attached is a small patch that fixes an inheritance problem with
> kconfig_compiler, as seen in KNotes for example: I have a class KNoteConfig
> that takes a file name argument and a class KNotesGlobalConfig which is a
> singleton that is supposed to inherit KNoteConfig. This does not compile
> with the current kconfig_compiler because the CTOR in the singleton calls
> the base class without arguments and the KNoteConfig CTOR has only
>   KNoteConfig( KSharedConfig::Ptr config )
> The attached patch changes this to
>   KNoteConfig( KSharedConfig::Ptr config = KGlobal::sharedConfig() )
> in case there are no parameters specified.
>
> Thoughts, objections?

Yes, looks good. Can you add a testcase to the regression tests for this 
situation as well, and update them where needed?

Cheers,
Waldo
-- 
bastian at kde.org   |   Free Novell Linux Desktop 9 Evaluation Download
bastian at suse.com  |   http://www.novell.com/products/desktop/eval.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050216/6bb25268/attachment.sig>