KRecentFiles patch

David Faure faure at kde.org
Mon Dec 12 19:12:21 GMT 2005


On Monday 12 December 2005 19:55, Albert Astals Cid wrote:
> Hi, i need this patch so that bug 118103 
> http://bugs.kde.org/show_bug.cgi?id=118103 does not happen.
> 
> I guess the mentioned 
> 
>  KURL u = url; //make a copy (increase the reference counter?).
>            //Otherwise after d->m_urls.erase( title ) the url will be empty...
> 
> may be causing that.

Patch looks good; comment looks half-wrong, KURL isn't refcounted itself.
But indeed the erase() removes the url which "url" references,
so using u is safer.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list