Thiago Macieira thiago at
Wed Dec 7 19:42:31 GMT 2005

Nicolas Goutte wrote:
>> The whole diff has been read into memory by the time the license
>> checker is run. So it has just to concatenate the diff from the array
>> into one string and run the proper regexps against it.
>That is what is done currently. And you get memory overflows...

Hmm... indeed. My original version didn't join everything, but it didn't 
work either.

Also, it can't be what caused Michael's commit to fail, because the 
license check is run only when the file is first committed.

I think we could limit the license check to the first 30 lines or so of 
the file.

  Thiago Macieira  -  thiago (AT) - thiago (AT)
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

2. Tó cennan his weorc gearu, ymbe se circolwyrde, wearð se cægbord and se 
leohtspeccabord, and þa mýs cómon lator. On þone dæg, he hine reste.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <>

More information about the kde-core-devel mailing list