[PATCH] Fix kmix sytray icon disappears

Christian Esken esken at kde.org
Sun Dec 4 23:53:47 GMT 2005

Am Mittwoch, 23. November 2005 12:17 schrieb Ismail Donmez:
> Monday 21 November 2005 11:49 tarihinde, Ismail Donmez şunları yazmıştı:
> > Hi all,
> >
> > If you change any setting in kmix settings systray icon disappears.

I never had this problem. The call "mw->mixer()->readSetFromHWforceUpdate();" 
in KMixWindow::applyPrefs() should make sure that all information (icon, 
tooltip, context menu, ... ) will get properly refreshed.

> > Following patch fixes this. I would be glad if this makes to 3.5 release.
> Applied to SVN.

This patch doesn't look so good.
1) IMO it creates a memory leak, by not freeing/deleting the old 
2) After a config dialog apply we will have two KMixDockWidget's, after the 
next "apply" we have three KMixDockWidget's, and so on.
There might be several strange side effects, because of still connected 
signal/slots. Comment 8 in Bug 111152 
( https://bugs.kde.org/show_bug.cgi?id=111152#c8 ) might very well be 
explainable by this.
3) As far as I see, it updates the pixmap, but not the tooltip (and probably 
some more stuff like mute state in the context menu).

I'll try to do a checkout of KDE3.5 RC1. Any hints on reproducing this bug is 
greatly appreciated.


More information about the kde-core-devel mailing list