[Patch] two patches to compile kdelibs/khtml on windows

Maks Orlovich mo85 at cornell.edu
Sun Dec 4 14:58:36 GMT 2005


On Sunday 04 December 2005 04:40, Christian Ehrlicher wrote:
> Hi,
>
> I've attached two patches to compile khtml with mscv.

No, you haven't :-)

<snip>

> In tilecache.h I change struct TileCacheNode into class TileCacheNode to
> avoid compiler warnings.

I would prefer if you changed the forward declaration in tile.h to be accurate 
instead.

> The scond is a little bit more complicated.
> The win32 api sdk also defines some values (OPTIONAL, ABSOLUTE, RELATIVE
> and FOCUS_EVENT) and therefore I get compiler errors when an api-header
> is included somewhere. So I decided to undef those values in the
> specific headers before they get redefined. I have to include windows.h
> too to be sure it isn't included after the definition of the problematic
> enums.

Could you perhaps consider doing something like "fixwin32h.h", similar to the 
"fixx11h.h", so all the ugliness is localized? 

-Maks




More information about the kde-core-devel mailing list