[PATCH] a little optimization of KJS GarbageCollector

[Dirk Mueller]

On Thursday 01 December 2005 16:09, David Faure wrote:

> You lost me there. --enable-debug leads to -g3 without optimization

wrong. --enable-debug=full does that, which is a seriously broken option and 
needed only for those platforms that don't support DWARF2. None of the less 
ancient linux distributions should need that. 

> , for 
> reliable step-by-step debugging in gdb and backtraces.

for reliable backtraces -fno-inline is enough :)

> So, like everyone 
> who compiles kdelibs with debug enabled, I'm among the developers who
> benefit from an optimization like the one this thread is about;

Note that I don't object to the patch getting included at all (except that it 
makes us differ from safari tree for no good reason). I'm just pointing out 
that gcc's output from -O0 code is so utterly horrible and slow that the 
least of your worries is this particular patch. 

> and this 
> has nothing to do with -Wall does it? --enable-debug enables warnings too
> iirc, but how is that related?

-Wall does not work properly without -O2. With -O0 ALL code and dataflow 
analysis steps are disabled, and therefore warnings which use this 
information to trigger at all don't work either. 

> What do you expect? That everyone has two versions of kdelibs compiled,
> one with debug for debugging and one without debug for more performance
> and seeing all warnings? I don't think this is realistic.

I just expect people to use realistic compiler flags. 


-- 
Dirk//\