Adding noclosure to KDE_OPTIONS

Adriaan de Groot groot at kde.org
Sun Sep 19 21:25:42 BST 2004


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

In all of KDE CVS, as far as I can tell, there are exactly _two_ 
noinst_LIBRARIES which are Qt based (most noinsts are pure C convenience 
thingies). Once is kdepim/libemailfunctions, the other is somewhere in 
kdenetwork/kopete. The thing with noinsts is that they don't get the usual 
$(LIB_QT) added, and when you throw --enable-closure into the mix, they don't 
link at all anymore, since the (now required) references to libqt-mt and 
whaterver else aren't made.

In kdepim/, I added $(LIB_QT) and $(LIB_KDECORE) to _LIBADD, which makes it 
link again. In kopete, I can't tell so quickly what needs to be added, the 
library structure seems to be a bit of a mess. It suggests to me that we need 
something similar to KDE_OPTIONS=nofinal -- a KDE_OPTIONS=noclosure, that 
prevents closure in those places where we need it (alternatively, not doing 
closure on C++-based libs might work as well, but sounds trickier).

The attached patch adds this, and seems to work for libemailfunctions at 
least. OK?

- -- 
Don't worry, 't ain't no shame to be stupid - ol' mouse.
    GPG: FEA2 A3FE Adriaan de Groot
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)

iD8DBQFBTetPdqzuAf6io/4RAul3AJ4uHg/VOjXJptqYVtBCfcow9yYXXQCfSSFY
trZgYGSngTOJ7FOQR8/ovsY=
=+2aB
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: am_edit.diff
Type: text/x-diff
Size: 770 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040919/d274aecd/attachment.diff>


More information about the kde-core-devel mailing list