kfinddialog patch

David Faure faure at kde.org
Thu Sep 9 21:36:49 BST 2004


On Thursday 09 September 2004 22:37, Frans Englich wrote:
> On Thursday 09 September 2004 20:25, David Faure wrote:
> > On Thursday 09 September 2004 22:19, Albert Astals Cid wrote:
> > > Something like that?
> > >
> > > Please review again
> >
> > Looks good, thanks.
> 
> Would it be a good idea to also make the public API use enums, instead of a 
> number of bool functions?
> 
> For example, enabling a feature would be done like this:
> 
> setCapabilities( KFindDialog::BackwardsFind | capabilities() );

That works for app-capabilities, but when it comes to e.g. "I have a selection",
"now I don't have a selection"... those settings change over time, so it's easier
with a bool setter IMHO.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list