KMainWindow::toolBarIterator() issue

David Faure faure at kde.org
Mon Sep 6 10:32:01 BST 2004


On Sunday 05 September 2004 22:17, Benjamin Meyer wrote:
> With 3.3 out the door I spent a minute to go back and work on the
> KMainWindow::toolBarIterator() issue.  (see "ktoolbar and index value" thread
> from kde-core-devel in July and another one in eary Aug about the
> toolBarIterator() problem in kdevelop).  The short term fix was to generate
> the list of toolbars on the fly every time, a better long term fix was to add
> a function to KMainWindow that anyone could call for 3.4.  So that is what
> the attached patch does.  Feedback, comments, suggestions.

Good idea, but returning a QPtrList by value makes a deep-copy of the list
(yes, QPtrList sucks). But seeing how we have a QPtrListIterator in the 
public API already, I guess it's not possible to turn this into a QValueList before Qt 4.
Ah well. Go ahead then.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list