[PATCH] XML validity of kcfg files

Benjamin Meyer ben at meyerhome.net
Sat Oct 30 23:39:41 BST 2004

Hash: SHA1

On Saturday 30 October 2004 12:26 pm, Aaron J. Seigo wrote:
> On Saturday 30 October 2004 02:40, Christian Mueller wrote:
> > Benjamin Meyer's automatted tests revealed that several kcfg files
> > in kdebase do not conform to the DTD.  Here's a patch (against HEAD)
> > that rectifies this.  Ok to commit (if CVS lets me)?
> except for the Stringlist -> StringList change, they all seem to just be
> reordering of the tags

There are a bunch of problems in the kdegames files, looks like missing things 
in the dtd, but supported by kcfgcompiler?  if the dtd is our doc, but the 
compiler supports features not listed...then this test is doing its job.  
Haven't fully looked into the reason for those kdegames errors so just my 
first guess.

> , e.g. max after default instead of before. does 
> re-ording the tags really make any difference? sounds to me like the script
> is reporting a lot of false positives?

XML files are invalid if only one thing is not to the dtd.  That is the point 
of XML :)  So the tools don't have tons of little work arounds for  broken 
tags (think html).

I don't know of any reason why it shouldn't validate.  But I will watch the 
thread and if it is decided that having invalid xml files is fine long term I 
will remove the test from the report.

- -Benjamin Meyer

- -- 
aka icefox
Public Key: http://www.csh.rit.edu/~benjamin/public_key.asc
Version: GnuPG v1.2.3 (GNU/Linux)


More information about the kde-core-devel mailing list