ifndef __FILE_H__

Matt Rogers mattr at kde.org
Thu Oct 28 04:10:13 BST 2004


On Wednesday 27 October 2004 09:16 pm, Benjamin Meyer wrote:
> According to the C++ Standard, 17.4.3.1.2 Global Names [lib.global.names],
> paragraph 1:
>
> Certain sets of names and function signatures are always reserved to the
> implementation:
> Each name that contains a double underscore (__) or begins with an
> underscore followed by an uppercase letter (2.11) is reserved to the
> implementation for any use.
> Each name that begins with an underscore is reserved to the implementation
> for use as a name in the global namespace.
>
> So.....  this means that a large number of headers in KDE should be changed
> from __FILE_H__ or _FILE_H_ to FILE_H  or [fill in with your idea here]
>
> I was never taught one way or the other and just copied what others did.  I
> presume the same of everyone else?
>
> What would be the best way to handle this?
> a) Ignore it
> b) Fix over time little by little
> c) Scripty/or other fix majority with a script now
> d) ?
>

I want A. Ever heard of "if it ain't broke, don't fix it"? Since the compiler 
doesn't barf on it, I don't see the problem.

Matt




More information about the kde-core-devel mailing list