[PATCH] kdelibs: isNull() instead of QString::null

Stephan Kulow coolo at kde.org
Wed Oct 27 09:28:22 BST 2004

Am Wednesday 27 October 2004 09:19 schrieb Craig Drummond:
> > Another patch to kdelibs in response to the automated test script
> > report linked on dot.kde.org. This time it's to replace checks for str
> > != QString::null with !str.isNull().
> Should this not be str.isEmpty()?
I don't see why. You're at high risk of breaking the code. And if really is
only interesting if there is something at all,there is little point in adding
an extra check of an empty string. The exercise of these patches are to
save as many asm instructions as possible.

Greetings, Stephan

More information about the kde-core-devel mailing list