Fwd: Re: patch for kurlcompletion.cpp

Stefan Teleman steleman at nyc.rr.com
Sun Oct 24 13:22:48 BST 2004

On Sunday 24 October 2004 04:37, you wrote:
> And why do you use bzero if you want to achieve portable code?

bzero is defined in the BSD Compatibility section of SVR4. Why is
bzero not portable ? yes i know that 15 years ago it didnt handle
overlapping memory correctly. this is no longer the case.

> And what's the deal with this code?
> -               d->dirListThread->wait( 200 );
> +               d->dirListThread->wait(); // 200ms wait does not
> work on Solaris
> Why not fix that problem on Solaris instead of making everyone
> suffer?

This is actually not related to Solaris at all. Is there any
 guarantee somewhere that the dirListThread thread will finish its
 job in 200 ms or less ? What if it takes 202 ms to finish, and
 addMatches( d->dirListThread->matches() ); is called while the other
 thread is still filling in the list ? This is not thread safe.


Stefan Teleman          'Nobody Expects the Spanish Inquisition'
steleman at nyc.rr.com                          -Monty Python

More information about the kde-core-devel mailing list