QString latin1 comparision

Stephan Kulow coolo at kde.org
Sat Oct 16 12:15:15 BST 2004


Am Samstag 16 Oktober 2004 11:07 schrieb Benjamin Meyer:
> From http://lists.kde.org/?l=kde-core-devel&m=107918336006593&w=2 I have
> written a script (for the kde automated testing) that finds all cases of it
> such as:
>
> Checking: kdebase
> table.setSelected(i/3,args[i+2]==QString::fromLatin1("on"));
> table.setSelected(i/3,args[i+2]==QString::fromLatin1("on"));
> ./kdialog/widgets.cpp
>
> Now after reading the whole thread I am unsure what to do.  Do I remove
> them in everything or everything but kdelibs or ?

No. we want these fromLatin1 to find the places where the encoding is assumed.
We should have more of NO_ASCI_CAST instead of less

Greetings, Stephan




More information about the kde-core-devel mailing list