[patch] refresh desktop icons

David Faure faure at kde.org
Sun Nov 21 00:46:42 GMT 2004

On Sunday 21 November 2004 00:03, Martin Koller wrote:
>  #if 0
>    m_bNeedRepaint |= 1;
>    updateWorkArea();
> -  refreshIcons();
>  #endif
>    kapp->dcopClient()->send( "kwin", "", "refresh()", "");
> +  refreshIcons();

Hmm. Yes. I disagree with George's comment above that code; kwin only
repaints, but not more. So we do need refreshIcons in there, there's 
no other way to trigger that code for the user.

Note: the refreshIcons in slotIconChanged should be removed, if refresh
takes care of that.

>          KFileIVI * fileIVI = static_cast<KFileIVI *>(it);
> +        fileIVI->item()->refresh();
> +        fileIVI->item()->refreshMimeType();

Hmm. The docu says refresh() should be enough. But the code disagrees. Fixed.

David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

More information about the kde-core-devel mailing list