[patch] refresh desktop icons

David Faure faure at kde.org
Sat Nov 20 18:34:59 GMT 2004

On Saturday 20 November 2004 18:35, Martin Koller wrote:
> Hi,
> the desktop currently has the problem, when having an icon on it which is a 
> link to a mounted directory, where the mount is currently not available, then 
> an "Unknown" Icon is shown.
> But when then the mount is established, the icon is not changed even when I 
> click "Refresh Desktop" in RMB.
> The patch fixes this by redetermining the Icon when refreshing.

Wrong place IMHO. When KDirLister notices changes and emits refreshItems,
it has already called refresh() on the KFileItems, so when konq_iconview.cc (for konq)
or KDIconView::slotRefreshItems (for kdesktop) calls KFileIVI::refreshIcon(), 
there's no need to do it again.

However you're right, that KDIconView::refreshIcons should do a KFileItem::refresh()
as well (not only the mimetype, maybe the permissions changed etc.). Please add it there.

David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

More information about the kde-core-devel mailing list