[PATCH] -fvisibility problems

Jaroslaw Staniek js at iidea.pl
Tue Nov 16 00:13:03 GMT 2004


> All kde modules are ready for use the -fvisibility options? I don't see 
> too much (any?) KDE_EXPORT macros out of kdelibs, e.g kdepim/libkdepim 
> has zero (and will have zero if it's supposed to work with KDE 3.3). 
> This breaks more things than --as-needed. It's a call for 
> --disable-fvisibility option, not?

Yes, a simple proposal is to disable visibility. Right now *_EXPORT macros are 
defined in places _only_ where it is needed for KDElibs/win32. gcc-visibility 
was a side effect that will be expanded for other modules. I didnt touch code 
that is not currently compiled on win32, sice I am not allowed to commit 
untested patches, no matter how almost-automatic is this work.

svgicons/ is one of these places.

I prepared a small list of rules for adding *_EXPORT's:

http://wiki.kde.org/tiki-index.php?page=KDElibs%2Fwin32+Porting+Guidelines#id481488

..for anybody who'd want to add these somewhere.

-- 
regards / pozdrawiam,
  Jaroslaw Staniek / OpenOffice Polska / Kexi Team
  Developers Wanted! Kexi 0.1 Beta 5 Released: http://www.kexi-project.org
  KDElibs/Windows: http://wiki.kde.org/tiki-index.php?page=KDElibs+for+win32




More information about the kde-core-devel mailing list