[PATCH] More missing $(all_libraries)
Szombathelyi György
gyurco at freemail.hu
Mon Nov 15 10:28:26 GMT 2004
Stephan Kulow wrote:
> On Sunday 14 November 2004 18:43, Szombathelyi Gy�rgy wrote:
>
>>Hello!
>>
>>The attached patches adds missing $(all_libraries) to Makefile ams in
>>various modules. This allows to fully exploit the --as-needed linker flag.
>>Any objections against applying?
>>
>
> From your arts patch (didn't look deeper):
> - $(KDE_MT_LDFLAGS) $(QT_LDFLAGS) $(USER_LDFLAGS) $(X_LDFLAGS)
> + $(KDE_MT_LDFLAGS) $(QT_LDFLAGS) $(USER_LDFLAGS) $(X_LDFLAGS)
> $(all_libraries)
>
> I have no idea what the KDE_MT_LDFLAGS is supposed to do, but what you do
> makes this whole setup pointless. When there is already QT_LDFLAGS you're
> duplicating it with adding all_libraries.
>
Ok, I'll correct the arts patch, but now the -fvisibility prevents it
from compiling :(.
Btw, another flag I encountered is KDE_LDFLAGS (in
kdemultimedia/akode/arts_plugin), which has similar functionality like
KDE_MT_LDFLAGS.
> Greetings, Stephan
>
Bye,
György
More information about the kde-core-devel
mailing list