[PATCH] SHA1 in kdelibs/kdecore/kmdcodec
mattr at kde.org
Sun Nov 7 04:27:28 GMT 2004
On Saturday 06 November 2004 05:20 pm, Szombathelyi György wrote:
> What about adding an SHA1 implementation to kmdcodec? There are at least
> four independent SHA1 code in the various KDE modules, it would be good to
> have only one. I took the implementation from Kopete.
> The patch also contains the modifications in kwallet to use the new code.
> Should I commit?
Which implementation did you take? AFAIK, the implementation(s) in Kopete is
not (L)GPL compatible. I need to sync the parts of the protocols that aren't
(L)GPL compatible before the next release, but that hasn't been done yet.
Also, I think we ought to just be using qca for this kind of stuff, so IMHO,
there's no point in adding new stuff to kmdcodec. However, the switch to qca
for kdelibs shouldn't come before KDE 4 due to BC reasons, IIRC.
More information about the kde-core-devel