[PATCH] Fix deprecated warnings in klistview.cpp
Lubos Lunak
l.lunak at suse.cz
Fri Nov 5 09:31:43 GMT 2004
On Friday 05 of November 2004 07:26, Ismail Donmez wrote:
> Hi all,
>
> Attached a small patch which replaces KApplication::keyboardModifiers()
> with KApplication::keyboardMouseState() in klistview.cpp to fix deprecated
> warnings.
>
> Can someone please review?
That doesn't look right, why have you changed it from bit operations to
comparions? In the first snippet 'if(keybstate != Qt::ControlButton)' will be
always true because of the first condition.
PS: Please add -p to your diff flags.
--
Lubos Lunak
KDE developer
---------------------------------------------------------------------
SuSE CR, s.r.o. e-mail: l.lunak at suse.cz , l.lunak at kde.org
Drahobejlova 27 tel: +420 2 9654 2373
190 00 Praha 9 fax: +420 2 9654 2374
Czech Republic http://www.suse.cz/
More information about the kde-core-devel
mailing list