KProcess: writeStdin API braindamage

Oswald Buddenhagen ossi at kde.org
Tue Mar 23 21:33:55 GMT 2004


On Tue, Mar 23, 2004 at 06:30:18PM +0100, Waldo Bastian wrote:
> > > This patches corrects that, by making a local copy of the data if
> > > the data could not be directly written into the pipe. This fixes
> > > pasting large amounts of data into konsole.
> >
> > i don't like it. the behaviour is clearly documented; working around
> > usage errors will certainly lead to other problems. fix the apps
> > instead.
> 
> It's a pain to work around and much more efficient to do it in
> kprocess.  It's simply a very unintuitive restriction on the API and
> as the patch shows, it can be easily solved.
> 
no. subverting documented behaviour cannot be good. you are making
correctly behaving applications less efficient.
you know the proper fix. this certainly can be done without breaking BC,
even. add KProcess::setBuffered( Communication mask ) and merge KProcIO,
putting the relevant code paths in if()s.
in any case the applications have to be fixed.

greetings

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.




More information about the kde-core-devel mailing list