[PATCH] KParts::ReadWritePart::saveAs - again ;-)

David Faure faure at kde.org
Wed Mar 10 13:30:57 GMT 2004

On Wednesday 10 March 2004 14:09, Andras Mantia wrote:
> On Wednesday 10 March 2004 14:51, David Faure wrote:
> > On Wednesday 10 March 2004 13:36, Andras Mantia wrote:
> > > So in case of a local file completed() is emitted if saveFile() returns
> > > true.
> >
> > Oh. I had missed that fact. Then it would be consistent to emit canceled
> > too. With QString::null as argument, since anything else would be shown to
> > the user in a message box, and it's hard at that point to know why it
> > failed (giving a non-empty string there would break koffice).
> Ok. May I do in BRANCH as well?

Hmm, maybe we should test it in HEAD for a little bit first, no?

If you don't forget to backport it later, that would seem safer IMHO,
otherwise backport now and we'll also backport fixes if any is necessary.

(I know I would forget to backport later myself :-)

David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).

More information about the kde-core-devel mailing list