[PATCH] KListViewSearchLine fix

Ingo Klöcker kloecker at kde.org
Mon Jun 14 20:45:45 BST 2004


On Thursday 10 June 2004 22:05, Andras Mantia wrote:
> On Thursday 10 June 2004 21:34, Ingo Klöcker wrote:
> > I didn't profile Andras' code. If someone wants to check his code
> > here are some macros that I've used to count the number of calls:
>
> I'm pretty sure that mine isn't efficient at all in many cases (when
> the elements are one by one removed starting from the deepest
> children, and each time the whole list is scanned), so if your patch
> fixes the bug, I'm happy with it.

Okay. I've already committed our local kdepim copy of it. But since I 
don't use kdelibs HEAD could please somebody else commit it to kdelibs 
HEAD? TIA. Attached is the cvs diff for the kdepim copy. After 
s/_pimcopy// it should apply cleanly to the files in kdelibs.

Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: klistviewsearchline_pimcopy.patch
Type: text/x-diff
Size: 4655 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040614/0d5b4abe/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20040614/0d5b4abe/attachment.sig>


More information about the kde-core-devel mailing list